linux-kernel - Re: [PATCH] lockdep: Include all lock classes in all_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080203194756.GA28783@farnsworth.org>
Date:	Sun, 3 Feb 2008 12:47:56 -0700
From:	Dale Farnsworth <dale@...nsworth.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep: Include all lock classes in all_lock_classes

On Sun, Feb 03, 2008 at 04:21:02PM +0100, Peter Zijlstra wrote:
> On Fri, 2008-02-01 at 08:21 -0700, Dale Farnsworth wrote:
> > Add each lock class to the all_lock_classes list when it is
> > first registered.
> > 
> > Previously, lock classes were added to all_lock_classes when
> > the lock class was first used. 
> 
> > Since one of the uses of the list is to find unused locks, this didn't
> > work well.
> 
> You mean in lockdep_proc.c to generate the statistics?

Yes, that's where I noticed it.  On my platform, there was one
unused lock which was missed.
> 
> Another potential issue might be count_matching_names() generating a
> wrong class version.

I haven't looked into that issue yet.

-Dale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/