linux-kernel - Re: [PATCH] IPV4: fix compile error building without CONFIG_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 Feb 2008 11:16:24 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	yoshfuji@...ux-ipv6.org
CC:	davem@...emloft.net, linux-net@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IPV4: fix compile error building without CONFIG_FS_PROC

YOSHIFUJI Hideaki wrote:
> In article <47A660A1.5080504@...fujitsu.com> (at Mon, 04 Feb 2008 08:47:29 +0800), Li Zefan <lizf@...fujitsu.com> says:
> 
>> compile error building without CONFIG_FS_PROC.
> :
>> The exit method should have no return values...
> 
> Have you really tested this with CONFIG_FS_PROC?
> 
> --yoshfuji
> 
> 

Oops, shame on me, what a silly patch... :( I tested it without CONFIG_PROC_PS,
but didn't test it with CONFIG_PROC_FS.

Now I've tested the new patch both with and without CONFIG_PROC_FS.

---

compile error building without CONFIG_FS_PROC:

net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_
init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_
exit'

Signed-off-by: Li Zefan <lizf@...fujitsu.com>

---
 include/net/ip_fib.h |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
index 90d1175..8b12667 100644
--- a/include/net/ip_fib.h
+++ b/include/net/ip_fib.h
@@ -266,6 +266,14 @@ static inline void fib_res_put(struct fib_result *res)
 #ifdef CONFIG_PROC_FS
 extern int __net_init  fib_proc_init(struct net *net);
 extern void __net_exit fib_proc_exit(struct net *net);
+#else
+static inline int fib_proc_init(struct net *net)
+{
+	return 0;
+}
+static inline void fib_proc_exit(struct net *net)
+{
+}
 #endif
 
 #endif  /* _NET_FIB_H */
-- 
1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/