linux-kernel - Re: [PATCH] x86: vmlinux_64.lds.S - use THREAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080204203315.GA31341@elte.hu>
Date:	Mon, 4 Feb 2008 21:33:15 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Cyrill Gorcunov <gorcunov@...il.com>, Andi Kleen <ak@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: vmlinux_64.lds.S - use THREAD_SIZE instead of
	numeric constant


* Sam Ravnborg <sam@...nborg.org> wrote:

> Hi Cyrill.
> On Mon, Feb 04, 2008 at 08:10:37PM +0300, Cyrill Gorcunov wrote:
> > Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
> 
> The patch looks simple but please explain why you do what you do. It 
> took me some digging before I could convince mysleft this was indeed a 
> correct change. And I am pretty sure you did the same investigation 
> yourself.
> 
> A comment like:
> 
> arch/x866/kernel/inittask.c require all variables allocated in
> the section .data.init_task to be aligned with THREAD_SIZE.
> 
> would have made me happy.

Btw., given that on x86 we've moved away from the %esp based task stack 
trick and use an %fs based Percpu-Data-Area (PDA) to access the current 
task pointer, this alignment might not be necessary anymore. It's a 
historic relic of the mask-%esp trick.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/