linux-kernel - Re: [PATCH 2/4 v2] hotplug cpu move tasks in empty cpusets to parent various other fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080204135606.b6e1a065.akpm@linux-foundation.org>
Date:	Mon, 4 Feb 2008 13:56:06 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	cpw@....com (Cliff Wickman)
Cc:	linux-kernel@...r.kernel.org, pj@....com, clameter@....com,
	rientjes@...gle.com, menage@...gle.com, cpw@....com,
	Lee.Schermerhorn@...com
Subject: Re: [PATCH 2/4 v2] hotplug cpu move tasks in empty cpusets to
 parent various other fixes


Confused.

On Mon, 04 Feb 2008 11:40:51 -0600
cpw@....com (Cliff Wickman) wrote:

> From: cpw@....com (Cliff Wickman)
> To: linux-kernel@...r.kernel.org
> Cc: pj@....com, clameter@....com, rientjes@...gle.com, menage@...gle.com, cpw@....com, Lee.Schermerhorn@...com, akpm@...ux-foundation.org
> Subject: [PATCH 2/4 v2] hotplug cpu move tasks in empty cpusets to parent various other fixes
> Date: Mon, 04 Feb 2008 11:40:51 -0600
> User-Agent: nail 11.25 7/29/05
> 
> 

The above implies that the patch was authored by Cliff.

> Various minor formatting and comment tweaks to Cliff Wickman's
> [PATCH_3_of_3]_cpusets__update_cpumask_revision.patch
> 
> I had had "iff", meaning "if and only if" in a comment.

And the "I" here implies that the patch was authored by Cliff.

> However, except for ancient mathematicians, the abbreviation
> "iff" was a tad too cryptic.  Cliff changed it to "if",
> presumably figuring that the "iff" was a typo.  However, it
> was the "only if" half of the conjunction that was most
> interesting.  Reword to emphasis the "only if" aspect.
> 
> The locking comment for remove_tasks_in_empty_cpuset() was wrong;
> it said callback_mutex had to be held on entry.  The opposite
> is true.
> 
> Several mentions of attach_task() in comments needed to be
> changed to cgroup_attach_task().
> 
> A comment about notify_on_release was no longer relevant,
> as the line of code it had commented, namely:
> 	set_bit(CS_RELEASED_RESOURCE, &parent->flags);
> is no longer present in that place in the cpuset.c code.
> 
> Similarly a comment about notify_on_release before the
> scan_for_empty_cpusets() routine was no longer relevant.
> 
> Removed extra parentheses and unnecessary return statement.
> 
> Renamed attach_task() to cpuset_attach() in various comments.
> 
> Removed comment about not needing memory migration, as it
> seems the migration is done anyway, via the cpuset_attach()
> callback from cgroup_attach_task().
> 
> Signed-off-by: Paul Jackson <pj@....com>
> Acked-by: Cliff Wickman <cpw@....com>

But the signoffs imply that Paul was the author.

I'm going to assume it was Paul.

We indicate authorship by putting a "From: foo <bar@....com>" at the very
first line of the changelog.  If that is absent then we use the From: from email
headers.

Please remember to do this - it is more reliable than akpm forensics.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/