linux-kernel - [drivers/scsi/NCR53C9x.c] remove duplication for family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <47A79022.4010302@tiscali.nl>
Date:	Mon, 04 Feb 2008 23:22:26 +0100
From:	Roel Kluin <12o3l@...cali.nl>
To:	garloff@...e.de, g.liakhovetski@....de,
	lkml <linux-kernel@...r.kernel.org>
Subject: [drivers/scsi/NCR53C9x.c] remove duplication for family_code == 0x00

in drivers/scsi/NCR53C9x.c:412-422 it reads:

                else if(family_code == 0x00) {
                        if ((version & 7) == 2)
                                esp->erev = fas100a; /* NCR53C9X */
                        else
                                esp->erev = espunknown;
                } else if(family_code == 0x14) {
                        if ((version & 7) == 2)
                                esp->erev = fsc;
                        else
                                esp->erev = espunknown;
                } else if(family_code == 0x00) {
                        if ((version & 7) == 2)
                                esp->erev = fas100a; /* NCR53C9X */
                        else
                                esp->erev = espunknown;

Note the duplication of test 'if(family_code == 0x00)' and lines below

Signed-off-by: Roel Kluin <12o3l@...cali.nl>
---
diff --git a/drivers/scsi/NCR53C9x.c b/drivers/scsi/NCR53C9x.c
index 5b0efc9..b8df3c0 100644
--- a/drivers/scsi/NCR53C9x.c
+++ b/drivers/scsi/NCR53C9x.c
@@ -419,11 +419,6 @@ static void esp_reset_esp(struct NCR_ESP *esp, struct ESP_regs *eregs)
 				esp->erev = fsc;
 		        else
 				esp->erev = espunknown;
-		} else if(family_code == 0x00) {
-			if ((version & 7) == 2)
-				esp->erev = fas100a; /* NCR53C9X */
-			else
-				esp->erev = espunknown;
 		} else
 			esp->erev = espunknown;
 		ESPLOG(("esp%d: FAST chip is %s (family=%d, version=%d)\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/