linux-kernel - Re: [alsa-devel] [PATCH][sound/soc/fsl/mpc8610_hpcd.c] duplicate strcasecmp test for "rj-master" in mpc8610_hpcd_probe()

Open Source and information security mailing list archives

Message-ID: <47A79D09.6090806@freescale.com>
Date:	Mon, 04 Feb 2008 17:17:29 -0600
From:	Timur Tabi <timur@...escale.com>
To:	Roel Kluin <12o3l@...cali.nl>, Timur Tabi <timur@...escale.com>,
	liam.girdwood@...fsonmicro.com, alsa-devel@...a-project.org,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH][sound/soc/fsl/mpc8610_hpcd.c] duplicate
 strcasecmp test for "rj-master" in mpc8610_hpcd_probe()

Mark Brown wrote:
> On Mon, Feb 04, 2008 at 10:08:02PM +0100, Roel Kluin wrote:
>> In linus' git tree I found this problem. Is it also in the alsa tree?
>> please confirm it's the right fix. The patch was not yet tested.
> 
> Timur, this looks like a good catch?

Yes, thank you!  The change below should be made.

> 
>> --
>> duplicate test for "rj-master"
>>
>> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
>> ---
>> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
>> index f26c4b2..a00aac7 100644
>> --- a/sound/soc/fsl/mpc8610_hpcd.c
>> +++ b/sound/soc/fsl/mpc8610_hpcd.c
>> @@ -314,9 +314,9 @@ static int mpc8610_hpcd_probe(struct of_device *ofdev,
>>  	} else if (strcasecmp(sprop, "lj-master") == 0) {
>>  		machine_data->dai_format = SND_SOC_DAIFMT_LEFT_J;
>>  		machine_data->codec_clk_direction = SND_SOC_CLOCK_IN;
>>  		machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT;
>> -	} else if (strcasecmp(sprop, "rj-master") == 0) {
>> +	} else if (strcasecmp(sprop, "rj-slave") == 0) {
>>  		machine_data->dai_format = SND_SOC_DAIFMT_RIGHT_J;
>>  		machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT;
>>  		machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN;
>>  	} else if (strcasecmp(sprop, "rj-master") == 0) {
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives