linux-kernel - Re: [PATCH 1/1 try#2] [INPUT] keypad driver: Added support for OpenCores Keyboard Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080205104242.GA11437@suse.cz>
Date:	Tue, 5 Feb 2008 11:42:42 +0100
From:	Vojtech Pavlik <vojtech@...e.cz>
To:	Bryan Wu <bryan.wu@...log.com>
Cc:	Will Newton <will.newton@...il.com>, dmitry.torokhov@...il.com,
	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org,
	Javier Herrero <jherrero@...istemas.es>
Subject: Re: [PATCH 1/1 try#2] [INPUT] keypad driver: Added support for
	OpenCores Keyboard Controller

On Thu, Jan 31, 2008 at 01:18:22AM +0800, Bryan Wu wrote:

> +static irqreturn_t opencores_kbd_isr(int irq, void *dev_id)
> +{
> +	unsigned char c;
> +	struct platform_device *pdev = dev_id;
> +	struct opencores_kbd *opencores_kbd = platform_get_drvdata(pdev);
> +	struct input_dev *input = opencores_kbd->input;
> +
> +	c = readb(opencores_kbd->addr_res->start);
> +	input_report_key(input, c & 0x7f, c & 0x80 ? 0 : 1);
> +	input_sync(input);
> +
> +	return IRQ_HANDLED;
> +}
 
This looks utterly wrong: It assumes 1:1 mapping between Linux keycodes
and what the keyboard sends, which I can't believe is the case.

-- 
Vojtech Pavlik
Director SuSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/