linux-kernel - Re: 2.6.24-mm1: ppc32: too few arguments to function 'reserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Feb 2008 16:00:08 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Mariusz Kozlowski <m.kozlowski@...land.pl>,
	linuxppc-dev@...abs.org, bwalle@...e.de, paulus@...ba.org,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.24-mm1: ppc32: too few arguments to function 'reserve_bootmem'

Hello.

Andrew Morton wrote:

>>	This is from ppc32:

>>  CC      arch/powerpc/mm/mem.o
>>arch/powerpc/mm/mem.c: In function 'do_init_bootmem':
>>arch/powerpc/mm/mem.c:256: error: too few arguments to function 'reserve_bootmem'
>>arch/powerpc/mm/mem.c:261: error: too few arguments to function 'reserve_bootmem'

>>Leftover from introduce-flags-for-reserve_bootmem.patch?

> Yes, I've had to fix that patch many times.

> --- a/arch/powerpc/mm/mem.c~introduce-flags-for-reserve_bootmem-powerpc-fix
> +++ a/arch/powerpc/mm/mem.c
> @@ -253,12 +253,13 @@ void __init do_init_bootmem(void)
>  				     lmb_size_bytes(&lmb.reserved, i) - 1;
>  		if (addr < total_lowmem)
>  			reserve_bootmem(lmb.reserved.region[i].base,
> -					lmb_size_bytes(&lmb.reserved, i));
> +					lmb_size_bytes(&lmb.reserved, i),
> +					BOOTMEM_DEFAULT);
>  		else if (lmb.reserved.region[i].base < total_lowmem) {
>  			unsigned long adjusted_size = total_lowmem -
>  				      lmb.reserved.region[i].base;
>  			reserve_bootmem(lmb.reserved.region[i].base,
> -					adjusted_size);
> +					adjusted_size, BOOTMEM_DWEFAULT);

    BOOTMEM_DWEFAULT, are you sure? :-)

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/