linux-kernel - Re: [PATCH 1/6] udf: udf_get_block, inode_bmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080205153005.GF25464@duck.suse.cz>
Date:	Tue, 5 Feb 2008 16:30:05 +0100
From:	Jan Kara <jack@...e.cz>
To:	marcin.slusarz@...il.com
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] udf: udf_get_block, inode_bmap - remove unneeded
	checks

On Sun 03-02-08 19:36:06, marcin.slusarz@...il.com wrote:
> block cannot be less than 0, because it's sector_t,
> so remove unneeded checks
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> Cc: Jan Kara <jack@...e.cz>
  Acked-by: Jan Kara <jack@...e.cz>

								Honza
> ---
>  fs/udf/inode.c |   12 ------------
>  1 files changed, 0 insertions(+), 12 deletions(-)
> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index c2d0477..531443d 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -323,9 +323,6 @@ static int udf_get_block(struct inode *inode, sector_t block,
>  
>  	lock_kernel();
>  
> -	if (block < 0)
> -		goto abort_negative;
> -
>  	iinfo = UDF_I(inode);
>  	if (block == iinfo->i_next_alloc_block + 1) {
>  		iinfo->i_next_alloc_block++;
> @@ -347,10 +344,6 @@ static int udf_get_block(struct inode *inode, sector_t block,
>  abort:
>  	unlock_kernel();
>  	return err;
> -
> -abort_negative:
> -	udf_warning(inode->i_sb, "udf_get_block", "block < 0");
> -	goto abort;
>  }
>  
>  static struct buffer_head *udf_getblk(struct inode *inode, long block,
> @@ -2081,11 +2074,6 @@ int8_t inode_bmap(struct inode *inode, sector_t block,
>  	int8_t etype;
>  	struct udf_inode_info *iinfo;
>  
> -	if (block < 0) {
> -		printk(KERN_ERR "udf: inode_bmap: block < 0\n");
> -		return -1;
> -	}
> -
>  	iinfo = UDF_I(inode);
>  	pos->offset = 0;
>  	pos->block = iinfo->i_location;
> -- 
> 1.5.3.7
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/