linux-kernel - Re: brk randomization breaks columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080205160913.GB28812@elte.hu>
Date:	Tue, 5 Feb 2008 17:09:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pavel Machek <pavel@....cz>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	kernel list <linux-kernel@...r.kernel.org>,
	Abel Bernabeu <abel.bernabeu@...il.com>,
	Hugh Dickins <hugh@...itas.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: brk randomization breaks columns


* Pavel Machek <pavel@....cz> wrote:

> > From: Jiri Kosina <jkosina@...e.cz>
> > 
> > brk: check the lower bound properly
> > 
> > There is a check in sys_brk(), that tries to make sure that we do not 
> > underflow the area that is dedicated to brk heap.
> > 
> > The check is however wrong, as it assumes that brk area starts immediately 
> > after the end of the code (+bss), which is wrong for example in 
> > environments with randomized brk start. The proper way is to check whether 
> > the address is not below the start_brk address.
> > 
> > Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> 
> ACK.

actually, does the patch above from Jiri solve the problem with your 11 
year old binaries too? (Sorry if it has been mentioned elsewhere, i 
could not decode it from this thread.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/