lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Feb 2008 13:59:52 -0500 From: "Mike Frysinger" <vapier.adi@...il.com> To: "Jiri Slaby" <jirislaby@...il.com> Cc: "Bryan Wu" <bryan.wu@...log.com>, linux-kernel@...r.kernel.org, "Mike Frysinger" <michael.frysinger@...log.com> Subject: Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory On Jan 30, 2008 6:00 AM, Jiri Slaby <jirislaby@...il.com> wrote: > On 01/30/2008 11:36 AM, Bryan Wu wrote: > > + > > + ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1); > > + if (ret) { > > + unregister_chrdev_region(bfin_otp_dev_node, 1); > > + printk(KERN_ERR PFX "unable to register char device\n"); > > + return ret; > > + } > > + > > + bfin_otp_class = class_create(THIS_MODULE, "otp"); > > + device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp"); > > Anyway, wouldn't be easier/better to use misc.c functionality here > (misc_register() et al.)? thanks, ive converted this now ... Bryan can post an updated patch :) http://blackfin.uclinux.org/gf/project/linux-kernel/scmsvn/?action=browse&path=/trunk/drivers/char/bfin-otp.c&r1=4224&r2=4223 -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists