| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47A8CCC0.8020703@microgate.com> Date: Tue, 05 Feb 2008 14:53:20 -0600 From: Paul Fulghum <paulkf@...rogate.com> To: Rick Warner <rick@...roway.com> CC: linux-kernel@...r.kernel.org Subject: Re: serial port regression caused by "Char: tty_ioctl, use wait_event_interruptible_timeout" patch Paul Fulghum wrote: > Instead of reverting the patch can you try modifying > this part of the patch: > > + if (wait_event_interruptible_timeout(tty->write_wait, > + !tty->driver->chars_in_buffer(tty), timeout)) > + return; > > by changing it to: > > + if (wait_event_interruptible_timeout(tty->write_wait, > + !tty->driver->chars_in_buffer(tty), timeout) < 0) > + return; > > It looks like the patch changed the behavior of > tty_wait_until_sent by not calling the driver > specific wait_until_sent if a timeout occurs. I mispoke, the patch changed the behavior by not calling the driver specific wait_until_sent if the condition is true. Original behavior: call driver->wait_until_sent() on timeout or true condition (skip for signal) Patch behavior: call driver->wait_until_sent() only on timeout (rc == 0) (skip for signal or true) By modifying the patch as described above, the original behavior is restored. -- Paul Fulghum Microgate Systems, Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists