linux-kernel - Re: [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080206095107.GA30596@elte.hu>
Date:	Wed, 6 Feb 2008 10:51:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	Pavel Emelyanov <xemul@...nvz.org>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>, jesse.brandeburg@...el.com,
	jeffrey.t.kirsher@...el.com, john.ronciak@...el.com,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	e1000-devel@...ts.sourceforge.net, Denis Lunev <den@...nvz.org>,
	Justin Piszcz <jpiszcz@...idpixels.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_32: fix regression caused by trim ram according to
	mtrr on system with 4G more RAM


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> [PATCH] x86_32: fix regression caused by trim ram according to mtrr on system with 4G more RAM
> 
> Pravel report:
> "
> The commit
> 
>         093af8d7f0ba3c6be1485973508584ef081e9f93
>         x86_32: trim memory by updating e820
> 
> broke my e1000 card: on loading driver says that
> 
>         e1000: probe of 0000:04:03.0 failed with error -5
> 
> and the interface doesn't appear.
> "
> 
> on 32 bit kernel, base will overflow when try to do PAGE_SHIFT. and 
> highest_addr will always less 4G.
> 
> so use pfn instead of address to avoid overflow when more than 4g
>  ram installed on 32bit kernel
> Many thanks for Pavel Emelyanov to report and test it.

thanks guys, applied.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/