linux-kernel - Re: [PATCH] sr: update to follow tray status correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47A9E9C6.4000802@gentoo.org>
Date:	Wed, 06 Feb 2008 17:09:26 +0000
From:	Daniel Drake <dsd@...too.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Maarten Bressers <mbres@...too.org>, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, axboe@...nel.dk, tasio@...rro.tasio.net
Subject: Re: [PATCH] sr: update to follow tray status correctly

Hi James,

James Bottomley wrote:
> It's been a while with no status on this one, so I corrected the patch
> based on my original input.  The attached is what I think is the best
> way of doing this (I've replaced the home grown test_unit_ready routine
> with the SCSI one and updated some of the sense check conditions).

Many thanks for following up on this. The user has not responded to my 
request for him to test your patch, so I decided to try it myself. I'm 
using Linus git as of today, I noticed the patch is merged.

It doesn't work for me. On unpatched 2.6.24, I get the behaviour 
previously described - the ioctl always gives CDS_TRAY_OPEN regardless 
of tray status. On 2.6.24-git which includes your patch, I instead 
always get CDS_DISC_OK. I have confirmed that on 2 systems this is 
because scsi_test_unit_ready() is returning 0.

Before I dig further, does this work for you? I have attached the test 
program I am using.

Thanks!
Daniel

View attachment "test.c" of type "text/plain" (685 bytes)