[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200802060248.00319.bzolnier@gmail.com>
Date: Wed, 6 Feb 2008 02:47:59 +0100
From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To: Denis Cheng <crquan@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...e.de>, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ide-pci-generic: kill the unused ifdef/endif/MODULE code
On Saturday 02 February 2008, Denis Cheng wrote:
> with module_param macro, the __setup code can be killed now:
> const __setup("all-generic-ide", ide_generic_all_on);
>
> and the module name "generic.ko" is not descriptive to its functionality,
> can be changed in Makefile, the "ide-pci-generic.ko" is better.
>
> the ide-pci-generic.all-generic-ide parameter also documented
> in Documentation/kernel-parameters.txt
>
> Signed-off-by: Denis Cheng <crquan@...il.com>
applied, thanks
PS the other patch will take same more time to review
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists