linux-kernel - Re: Ordering of commits and breaking bisecting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080207082227O.fujita.tomonori@lab.ntt.co.jp>
Date:	Thu, 07 Feb 2008 08:22:27 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	sfr@...b.auug.org.au
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, tomof@....org,
	fujita.tomonori@....ntt.co.jp
Subject: Re: Ordering of commits and breaking bisecting

On Wed, 6 Feb 2008 09:38:17 +1100
Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> Can we be a bit more careful with the ordering of commits, please?
> Commit d22a6966b8029913fac37d078ab2403898d94c63 (iommu sg merging: add
> accessors for segment_boundary_mask in device_dma_parameters())
> introduces the dma_get_seg_boundary accessor which is used in the
> *preceding* commits fb3475e9b6bfa666107512fbd6006c26014f04b8 (for
> powerpc), and 1b39b077789955c8389488d53d075518fdcd582e and
> fde9a1094ddf2892188a8a0eccda527de47cba8e (for x86).
> 
> Thus we have another set of commits that will break bisection.  This one
> was easily avoidable.
> 
> A little more care is needed.

Sorry about it.

I submitted the patches in the proper order but the order seemed to be
reversed in the -mm.

http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg11919.html

I could have noticed the issue since it has been in the -mm for a long
time, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/