linux-kernel - Re: {2.6.22.y} quicklists must keep even off node pages on the quicklists until the TLB flush has been completed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080206060256.GA3836@linux.vnet.ibm.com>
Date:	Wed, 6 Feb 2008 11:32:56 +0530
From:	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
To:	Oliver Pinter <oliver.pntr@...il.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, stable@...nel.org,
	stable-commits@...r.kernel.org,
	Christoph Lameter <clameter@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	"chrisw@...s-sol.org" <chrisw@...s-sol.org>,
	Willy Tarreau <w@....eu>, Adrian Bunk <bunk@...nel.org>
Subject: Re: {2.6.22.y} quicklists must keep even off node pages on the
	quicklists until the TLB flush has been completed.

On Tue, Feb 05, 2008 at 10:06:02PM +0100, Oliver Pinter wrote:
> it is already im queue for 2.6.23,
> 
> ----8<-----
> >From stable-bounces@...ux.kernel.org Sat Dec 22 14:04:08 2007
> From: Christoph Lameter <clameter@....com>
> Date: Sat, 22 Dec 2007 14:03:23 -0800
> Subject: quicklists: do not release off node pages early
> To: torvalds@...ux-foundation.org
> Cc: stable@...nel.org, akpm@...ux-foundation.org,
> dhaval@...ux.vnet.ibm.com, clameter@....com
> Message-ID: <200712222203.lBMM3Nsk021922@...p1.linux-foundation.org>
> 
> 
> From: Christoph Lameter <clameter@....com>
> 
> patch ed367fc3a7349b17354c7acef551533337764859 in mainline.
> 
> quicklists must keep even off node pages on the quicklists until the TLB
> flush has been completed.
> 
> Signed-off-by: Christoph Lameter <clameter@....com>
> Cc: Dhaval Giani <dhaval@...ux.vnet.ibm.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> ---
>  include/linux/quicklist.h |    8 --------
>  1 file changed, 8 deletions(-)
> 
> --- a/include/linux/quicklist.h
> +++ b/include/linux/quicklist.h
> @@ -56,14 +56,6 @@ static inline void __quicklist_free(int
>  	struct page *page)
>  {
>  	struct quicklist *q;
> -	int nid = page_to_nid(page);
> -
> -	if (unlikely(nid != numa_node_id())) {
> -		if (dtor)
> -			dtor(p);
> -		__free_page(page);
> -		return;
> -	}
> 
>  	q = &get_cpu_var(quicklist)[nr];
>  	*(void **)p = q->page;
> 
> ---->8------
> Tested-by: Oliver Pinter <oliver.pntr@...il.com> (on i386)
> 

Christoph,

Is this one also supposed to be backported?

-- 
regards,
Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/