linux-kernel - Re: [PATCH] [drivers/misc/asus-laptop.c] add parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200802070042.29667.lenb@kernel.org>
Date:	Thu, 7 Feb 2008 00:42:29 -0500
From:	Len Brown <lenb@...nel.org>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	corentincj@...aif.net, acpi4asus-user@...ts.sourceforge.net,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [drivers/misc/asus-laptop.c] add parentheses

applied.

thanks,
-Len

On Saturday 02 February 2008 15:07, Roel Kluin wrote:
> '!' has a higher priority than '&': bitanding has no effect.
> 
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
> index 7dce318..65c67d1 100644
> --- a/drivers/misc/asus-laptop.c
> +++ b/drivers/misc/asus-laptop.c
> @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, int mask)
>  
>  	switch (mask) {
>  	case MLED_ON:
> -		out = !out & 0x1;
> +		out = !(out & 0x1);
>  		break;
>  	case GLED_ON:
>  		out = (out & 0x1) + 1;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/