linux-kernel - Re: [PATCH v2] mmc: extend ricoh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080207090834.3c6fde7d@poseidon.drzeus.cx>
Date:	Thu, 7 Feb 2008 09:08:34 +0100
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Frank Seidel <fseidel@...e.de>
Cc:	Philip Langdale <philipl@...rt.org>, sdhci-devel@...t.drzeus.cx,
	linux-kernel@...r.kernel.org,
	Andrew de Quincey <adq_dvb@...skialf.net>
Subject: Re: [PATCH v2] mmc: extend ricoh_mmc to support Ricoh RL5c476

On Mon, 4 Feb 2008 19:25:42 +0100
Frank Seidel <fseidel@...e.de> wrote:

> From: Frank Seidel <fseidel@...e.de>
> 
> This patch (base on current linus git tree plus Philip Langdales
> suspend/resume patch) adds support for the Ricoh RL5c476 chip:
> with this the mmc adapter that needs this disabler (R5C843) can
> also be handled correctly when it sits on a RL5c476.
> (+ minor style changes (removed spaces between function names
> and open parenthesis .. checkpatch warned from previos patch))
> 
> Signed-off-by: Frank Seidel <fseidel@...e.de>

I see you've guys have kept yourself busy in my absence. :)

As for the patch, it looks ok although I'm not really a fan of more voodoo constants that noone knows what they mean. Could you add some comments explaining some of them at least?

> +	if (fw_dev->device == PCI_DEVICE_ID_RICOH_RL5C476) {

*snip*

> +	} else {
> +		/* via R5C832 */

Wouldn't it be prudent to have a check that this is indeed a R5C832, and a failure mode if it's none of the two known devices?

Rgds
Pierre

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)