linux-kernel - Re: [PATCH] x86_64: clean up find_e820

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Feb 2008 09:12:39 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <Yinghai.Lu@....COM>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: clean up find_e820_area


* Yinghai Lu <Yinghai.Lu@....COM> wrote:

> [PATCH] x86_64: clean up find_e820_area
> 
> change size to unsigned long, becase caller and user all used unsigned 
> long. also make bad_addr take align.

thanks, applied.

[ tiny nitpicking detail:

 > -static inline int bad_addr(unsigned long *addrp, unsigned long size)
 > +static inline int bad_addr(unsigned long *addrp, unsigned long size, unsigned long align)

 please run scripts/checkpatch.pl over your patches, that would have 
 caught the above overlong line. ]

> @@ -105,7 +105,7 @@ again:
>  	for (i = 0; i < MAX_EARLY_RES && early_res[i].end; i++) {
>  		struct early_res *r = &early_res[i];
>  		if (last >= r->start && addr < r->end) {
> -			*addrp = addr = r->end;
> +			*addrp = addr = round_up(r->end, align);

nice! This makes the reservation intent and effect much clearer.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/