linux-kernel - Re: [PATCH] Use global TLB flushes in MTRR code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6101e8c40802071108i4e66be5r4e9a6e77421beaae@mail.gmail.com>
Date:	Thu, 7 Feb 2008 20:08:04 +0100
From:	"Oliver Pinter" <oliver.pntr@...il.com>
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	mingo@...e.hu, davej@...emonkey.org.uk, tglx@...utronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use global TLB flushes in MTRR code

and old-stable (eg 2.6.22)?

On 2/7/08, Andi Kleen <andi@...stfloor.org> wrote:
> [probably stable material too]
>
> Use global TLB flushes in MTRR code
>
> Obviously kernel mappings should be flushed here too.
>
> Signed-off-by: Andi Kleen <ak@...e.de>
>
> ---
>  arch/x86/kernel/cpu/mtrr/generic.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/arch/x86/kernel/cpu/mtrr/generic.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/cpu/mtrr/generic.c
> +++ linux/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -356,7 +356,7 @@ static void prepare_set(void) __acquires
>  	}
>
>  	/* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */
> -	__flush_tlb();
> +	__flush_tlb_all();
>
>  	/*  Save MTRR state */
>  	rdmsr(MTRRdefType_MSR, deftype_lo, deftype_hi);
> @@ -368,7 +368,7 @@ static void prepare_set(void) __acquires
>  static void post_set(void) __releases(set_atomicity_lock)
>  {
>  	/*  Flush TLBs (no need to flush caches - they are disabled)  */
> -	__flush_tlb();
> +	__flush_tlb_all();
>
>  	/* Intel (P6) standard MTRRs */
>  	mtrr_wrmsr(MTRRdefType_MSR, deftype_lo, deftype_hi);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/