linux-kernel - Re: out-of-bounds array index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802071128.55935.jesse.barnes@intel.com>
Date:	Thu, 7 Feb 2008 11:28:55 -0800
From:	Jesse Barnes <jesse.barnes@...el.com>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	Jens Axboe <jens.axboe@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: out-of-bounds array index

On Thursday, February 07, 2008 11:21 am Jan Engelhardt wrote:
> On Feb 7 2008 19:56, Jens Axboe wrote:
> >Just saw this from gcc:
> >
> >drivers/char/drm/i915_drv.c: In function ?i915_suspend?:
> >drivers/char/drm/i915_drv.c:173: warning: array subscript is above array
> >bounds
> >  CC [M]  drivers/char/drm/i915_dma.o
> >drivers/char/drm/i915_drv.c: In function ?i915_resume?:
> >drivers/char/drm/i915_drv.c:220: warning: array subscript is above array
> >bounds
> >
> >It's this code:
> >
> >        dev_priv->saveGR[0x18] =
> >                i915_read_indexed(VGA_GR_INDEX, VGA_GR_DATA, 0x18);
> >
> >which looks legit, since saveGR is
>
> It is not legit at all. 0x18 is the 25th position in the array,
> but it is only 24 big. (Excluding play-hide-and-seek games like
> allocating more in case of malloc or char *foo[0].)

I think he was saying that the warning was legit.  Anyway, my gcc isn't smart 
enough to emit warnings like this, maybe it's time to ugprade...

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/