[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080207205021.GB16628@sergelap.ibm.com>
Date: Thu, 7 Feb 2008 14:50:21 -0600
From: "Serge E. Hallyn" <serue@...ibm.com>
To: Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc: Pavel Emelyanov <xemul@...nvz.org>,
Linux Containers <containers@...ts.osdl.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Paul Menage <menage@...gle.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][DOCUMENTATION] Minimal controller code for a quick
start
Quoting Peter Zijlstra (a.p.zijlstra@...llo.nl):
>
> On Thu, 2008-02-07 at 18:37 +0300, Pavel Emelyanov wrote:
> > The Documentation/cgroups.txt file contains the info on how
> > to write some controller for cgroups subsystem, but even with
> > this, one need to write quite a lot of code before developing
> > the core (or copy-n-paste it from some other place).
> >
> > I propose to put this minimal controller into Documentation
> > directory to let people copy-n-paste a) from a known place and
> > b) a small piece of code.
> >
> > Besides, many people learn better reading an example rather
> > than/along with a document.
>
>
> While on the subject, could someone document struct cgroup_subsys. In
> particular, I've wondered why we have: cgroup_subsys::can_attach() and
The point of can_attach() is to decide whether an attach should be
permitted. kernel/ns_cgroup.c defines it.
> not use a return value in cgroup_subsys::attach()?
IIUC, by the point ->attach() is called, the task has already been placed
in the new cgroup, and we're just asking each subsystem to update any
relevant accounting.
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists