linux-kernel - Re: [PATCH -mm] apanel: fix kconfig dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080207224658.2b9091bf@hyperion.delvare>
Date:	Thu, 7 Feb 2008 22:46:58 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	shemminger@...ux-foundation.org, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -mm] apanel: fix kconfig dependencies

Hi Randy,

On Thu, 7 Feb 2008 11:04:12 -0800, Randy Dunlap wrote:
> OK.  What did you have in mind for the help text.  I changed it
> a small bit.
> 
> I also added "depends on LEDS_CLASS" since defconfig didn't have that
> set, but the build failed with wanting symbols that it provides.
> 
> Updated patch:
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Add I2C to config since the driver makes several i2c*() calls.
> 
> Add to help text that the Intel I2C ICH (i801) driver is also needed
> for this kernel.
> 
> Add LEDS_CLASS to config since the driver makes les_classdev_*() calls:
> ERROR: "led_classdev_register" [drivers/input/misc/apanel.ko] undefined!
> ERROR: "__led_classdev_unregister" [drivers/input/misc/apanel.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/input/misc/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- linux-2.6.24-mm1.orig/drivers/input/misc/Kconfig
> +++ linux-2.6.24-mm1/drivers/input/misc/Kconfig
> @@ -42,14 +42,14 @@ config INPUT_M68K_BEEP
>  
>  config INPUT_APANEL
>  	tristate "Fujitsu Lifebook Application Panel buttons"
> -	depends on X86
> -	select I2C_I801
> +	depends on X86 && I2C && LEDS_CLASS
>  	select INPUT_POLLDEV
>  	select CHECK_SIGNATURE
>  	help
>  	 Say Y here for support of the Application Panel buttons, used on
>  	 Fujitsu Lifebook. These are attached to the mainboard through
> -	 an SMBus interface managed by the I2C Intel ICH (i801) driver.
> +	 an SMBus interface managed by the I2C Intel ICH (i801) driver,
> +	 which you should also build for this kernel.
>  
>  	 To compile this driver as a module, choose M here: the module will
>  	 be called apanel.

Yeah, looks OK to me.

Acked-by: Jean Delvare <khali@...ux-fr.org>

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/