| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Feb 2008 17:08:19 -0600 From: Eric Sandeen <sandeen@...hat.com> To: Andrew Morton <akpm@...ux-foundation.org> CC: linux-kernel@...r.kernel.org Subject: Re: [PATCH] reduce large do_mount stack usage with noinlines Andrew Morton wrote: > On Wed, 06 Feb 2008 17:11:38 -0600 > Eric Sandeen <sandeen@...hat.com> wrote: > >> /* >> * recursively change the type of the mountpoint. >> + * noinline this do_mount helper to save do_mount stack space. >> */ >> -static int do_change_type(struct nameidata *nd, int flag) >> +static noinline int do_change_type(struct nameidata *nd, int flag) > > What we could do here is defined a new noinline_because_of_stack_suckiness > and use that. Something like: Index: linux-2.6.24-mm1/include/linux/compiler-gcc.h =================================================================== --- linux-2.6.24-mm1.orig/include/linux/compiler-gcc.h +++ linux-2.6.24-mm1/include/linux/compiler-gcc.h @@ -53,3 +53,9 @@ #define noinline __attribute__((noinline)) #define __attribute_const__ __attribute__((__const__)) #define __maybe_unused __attribute__((unused)) + +/* + * When gcc inlines multiple functions into a parent function, + * the stack space used sometimes increases excessively... + */ +#define noinline_stackspace noinline ? I couldn't think of a great name for it. There are several noinline users throughout the kernel with stackspace related comments, so if desired, I could sprinkle this around. I'm not very pleased with it aesthetically though. :) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists