lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080208112709.GA12028@rakim.wolfsonmicro.main>
Date:	Fri, 8 Feb 2008 11:27:09 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org,
	Dmitry Baryshkov <dbaryshkov@...il.com>,
	Liam Girdwood <liam.girdwood@...fsonmicro.com>,
	Graeme Gregory <gg@...nsource.wolfsonmicro.com>,
	Rodolfo Giometti <giometti@...eenne.com>,
	Russell King <rmk@....linux.org.uk>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Ian Molton <spyro@....com>,
	Vincent Sanders <vince@...likki.org>,
	Andrew Zabolotny <zap@...elink.ru>
Subject: Re: [PATCH 1/6] Core driver for WM97xx touchscreens

On Thu, Feb 07, 2008 at 05:07:23PM -0500, Dmitry Torokhov wrote:

> The probe error handling is not quite correct. When we reach the fragment
> above ret variable is 0 so if platfrom_device_alloc() fails we will return
> 0 and the device will be considered bound but in half-dead state. Please
> make sure that proper error is returned in all cases. Also please do not
> mix out of line and in-line error unwinding (input_free_device() should
> be called in the error path and if you are concerned about double-free
> after input_unregister_device() just set wm->input_dev to NULL there).

Thanks for the review, I've implemented these changes and will resubmit
as a followup to this e-mail, also including a change from Dmitry
Baryshkov to make the devices unnumbered.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ