linux-kernel - Re: [-mm PATCH] sysdev_unregister() should call kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080208003825.GB27317@kroah.com>
Date:	Thu, 7 Feb 2008 16:38:25 -0800
From:	Greg KH <greg@...ah.com>
To:	Badari Pulavarty <pbadari@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote:
> Hi Greg,
> 
> While playing with hotplug memory remove on 2.6.24-mm1, I 
> noticed that /sysfs directory entries are not getting removed.
> 
> sysdev_unregister() used to call kobject_unregister().
> But in 2.6.24-mm1, its only dropping the ref. It should
> call kobject_del() to remove the object. Correct ?
> 
> With this change, the directories are getting removed
> correctly. Comments ?

Ick, no, this shouldn't be needed, someone else must be holding a
reference to the kobject device somewhere.  See the kobject documenation
for more info.

I'll try to see where we grab 2 references...

Have I mentioned lately that I hate the sysdev code?

ugh,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/