linux-kernel - Re: [PATCH 1/9] x86: change most X86_32 pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080208211344.GB15571@martell.zuzino.mipt.ru>
Date:	Sat, 9 Feb 2008 00:13:44 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Roland McGrath <roland@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] x86: change most X86_32 pt_regs members to unsigned long

On Fri, Feb 08, 2008 at 12:09:56PM -0800, Harvey Harrison wrote:
> All but ax and orig_ax can move with no changes.

> --- a/include/asm-x86/ptrace.h
> +++ b/include/asm-x86/ptrace.h
> @@ -36,23 +36,23 @@ struct pt_regs {
>  #else /* __KERNEL__ */
>  
>  struct pt_regs {
> -	long bx;
> -	long cx;
> -	long dx;
> -	long si;
> -	long di;
> -	long bp;
> +	unsigned long bx;
> +	unsigned long cx;
> +	unsigned long dx;
> +	unsigned long si;
> +	unsigned long di;
> +	unsigned long bp;
>  	long ax;
> -	int  ds;
> -	int  es;
> -	int  fs;
> +	unsigned long ds;
> +	unsigned long es;
> +	unsigned long fs;
>  	/* int  gs; */
>  	long orig_ax;
> -	long ip;
> -	int  cs;
> -	long flags;
> -	long sp;
> -	int  ss;
> +	unsigned long ip;
> +	unsigned long cs;
> +	unsigned long flags;
> +	unsigned long sp;
> +	unsigned long ss;

Why?! You don't have even minimal chances to unify pt_regs for i386 and
x86_64.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/