linux-kernel - Re: CONFIG_HIGHPTE vs. sub-page page tables.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080208230433.GA8524@elte.hu>
Date:	Sat, 9 Feb 2008 00:04:33 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: CONFIG_HIGHPTE vs. sub-page page tables.


* Linux Kernel Mailing List <linux-kernel@...r.kernel.org> wrote:

> Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4
> Commit:     2f569afd9ced9ebec9a6eb3dbf6f83429be0a7b4
> Parent:     13214adf738abc92b0a00c0763fd3be79eebaa7c
> Author:     Martin Schwidefsky <schwidefsky@...ibm.com>
> AuthorDate: Fri Feb 8 04:22:04 2008 -0800
> Committer:  Linus Torvalds <torvalds@...dy.linux-foundation.org>
> CommitDate: Fri Feb 8 09:22:42 2008 -0800
> 
>     CONFIG_HIGHPTE vs. sub-page page tables.

this patch broke the 32-bit x86 build after just 2 randconfig 
iterations:

 In file included from include/linux/memcontrol.h:25,
                 from include/linux/swap.h:9,
                 from include/linux/suspend.h:8,
                 from arch/x86/kernel/asm-offsets_32.c:12,
                 from arch/x86/kernel/asm-offsets.c:3:
 include/linux/mm.h:1151: error: expected declaration specifiers or '...' before 'pgtable_t'

config attached. It seems all !PAE 32-bit kernel builds are broken due 
to this. The patch below fixes it.

	Ingo

------------------->
Subject: x86: pgtable_t build fix
From: Ingo Molnar <mingo@...e.hu>

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 include/asm-x86/page_32.h |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Index: linux/include/asm-x86/page_32.h
===================================================================
--- linux.orig/include/asm-x86/page_32.h
+++ linux/include/asm-x86/page_32.h
@@ -49,11 +49,13 @@ typedef unsigned long	phys_addr_t;
 
 typedef union { pteval_t pte, pte_low; } pte_t;
 
-typedef struct page *pgtable_t;
-
 #endif	/* __ASSEMBLY__ */
 #endif	/* CONFIG_X86_PAE */
 
+#ifndef __ASSEMBLY__
+typedef struct page *pgtable_t;
+#endif
+
 #ifdef CONFIG_HUGETLB_PAGE
 #define HAVE_ARCH_HUGETLB_UNMAPPED_AREA
 #endif

View attachment "config" of type "text/plain" (41884 bytes)