linux-kernel - Re: [git pull] Input updates for 2.6.25-rc0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080208232536.GA15727@elte.hu>
Date:	Sat, 9 Feb 2008 00:25:36 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Dmitry Torokhov <dtor@...ightbb.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Stephen Hemminger <shemminger@...ux-foundation.org>
Subject: Re: [git pull] Input updates for 2.6.25-rc0


* Dmitry Torokhov <dtor@...ightbb.com> wrote:

> Stephen Hemminger (2):
>       Input: add driver for Fujitsu application buttons

this change broke the build on x86 in randconfig testing:

  drivers/built-in.o: In function `apanel_detach_client':
  apanel.c:(.text+0x15c120): undefined reference to  `__led_classdev_unregister'
  drivers/built-in.o: In function `apanel_probe':
  apanel.c:(.text+0x15c30f): undefined reference to  `led_classdev_register'

.config attached.

the Kconfig dependencies seem incomplete:

> +config INPUT_APANEL
> +     tristate "Fujitsu Lifebook Application Panel buttons"
> +     depends on X86
> +     select I2C_I801
> +     select INPUT_POLLDEV
> +     select CHECK_SIGNATURE
> +     help

it doesnt list LEDS.

	Ingo

View attachment "config" of type "text/plain" (50331 bytes)