linux-kernel - [patch] [git pull] Input updates for 2.6.25-rc0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080208153741.54409a7a.randy.dunlap@oracle.com>
Date:	Fri, 8 Feb 2008 15:37:41 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Dmitry Torokhov <dtor@...ightbb.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [patch] [git pull] Input updates for 2.6.25-rc0

On Fri, 8 Feb 2008 15:28:12 -0800 Stephen Hemminger wrote:

> On Sat, 9 Feb 2008 00:25:36 +0100
> Ingo Molnar <mingo@...e.hu> wrote:
> 
> > 
> > * Dmitry Torokhov <dtor@...ightbb.com> wrote:
> > 
> > > Stephen Hemminger (2):
> > >       Input: add driver for Fujitsu application buttons
> > 
> > this change broke the build on x86 in randconfig testing:
> > 
> >   drivers/built-in.o: In function `apanel_detach_client':
> >   apanel.c:(.text+0x15c120): undefined reference to  `__led_classdev_unregister'
> >   drivers/built-in.o: In function `apanel_probe':
> >   apanel.c:(.text+0x15c30f): undefined reference to  `led_classdev_register'
> > 
> > .config attached.
> > 
> > the Kconfig dependencies seem incomplete:
> > 
> > > +config INPUT_APANEL
> > > +     tristate "Fujitsu Lifebook Application Panel buttons"
> > > +     depends on X86
> > > +     select I2C_I801
> > > +     select INPUT_POLLDEV
> > > +     select CHECK_SIGNATURE
> > > +     help
> > 
> > it doesnt list LEDS.
> > 
> > 	Ingo
> 
> I think someone already sent a patch to select the LEDS

I did... and more.  Who will merge it?  (below)

---
From: Randy Dunlap <randy.dunlap@...cle.com>

Add I2C to config since the driver makes several i2c*() calls.

Add to help text that the Intel I2C ICH (i801) driver is also needed
for this kernel.

Add LEDS_CLASS to config since the driver makes les_classdev_*() calls:
ERROR: "led_classdev_register" [drivers/input/misc/apanel.ko] undefined!
ERROR: "__led_classdev_unregister" [drivers/input/misc/apanel.ko] undefined!

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 drivers/input/misc/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.24-mm1.orig/drivers/input/misc/Kconfig
+++ linux-2.6.24-mm1/drivers/input/misc/Kconfig
@@ -42,14 +42,14 @@ config INPUT_M68K_BEEP
 
 config INPUT_APANEL
 	tristate "Fujitsu Lifebook Application Panel buttons"
-	depends on X86
-	select I2C_I801
+	depends on X86 && I2C && LEDS_CLASS
 	select INPUT_POLLDEV
 	select CHECK_SIGNATURE
 	help
 	 Say Y here for support of the Application Panel buttons, used on
 	 Fujitsu Lifebook. These are attached to the mainboard through
-	 an SMBus interface managed by the I2C Intel ICH (i801) driver.
+	 an SMBus interface managed by the I2C Intel ICH (i801) driver,
+	 which you should also build for this kernel.
 
 	 To compile this driver as a module, choose M here: the module will
 	 be called apanel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/