linux-kernel - Fwd: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 9 Feb 2008 16:14:52 +0100
From:	"Oliver Pinter" <oliver.pntr@...il.com>
To:	"Greg KH" <greg@...ah.com>, stable@...nel.org
Cc:	"Christoph Lameter" <clameter@....com>,
	"Justin M. Forbes" <jmforbes@...uxtx.org>,
	"Greg KH" <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org,
	"Zwane Mwaikambo" <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	"Randy Dunlap" <rdunlap@...otime.net>,
	"Dave Jones" <davej@...hat.com>,
	"Chuck Wolber" <chuckw@...ntumlinux.com>,
	"Chris Wedgwood" <reviews@...cw.f00f.org>,
	"Michael Krufky" <mkrufky@...uxtv.org>,
	"Chuck Ebbert" <cebbert@...hat.com>,
	"Domenico Andreoli" <cavokz@...il.com>, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, dhaval@...ux.vnet.ibm.com
Subject: Fwd: [patch 22/27] quicklist: Set tlb->need_flush if pages are remaining in quicklist 0

for 2.6.22

---------- Forwarded message ----------
From: Oliver Pinter <oliver.pntr@...il.com>
Date: Thu, 7 Feb 2008 00:11:58 +0100
Subject: Re: [patch 22/27] quicklist: Set tlb->need_flush if pages are
remaining in quicklist 0
To: Greg KH <greg@...ah.com>
Cc: Christoph Lameter <clameter@....com>, "Justin M. Forbes"
<jmforbes@...uxtx.org>, Greg KH <gregkh@...e.de>,
linux-kernel@...r.kernel.org, stable@...nel.org,
torvalds@...ux-foundation.org, Zwane Mwaikambo
<zwane@....linux.org.uk>, Theodore Ts'o <tytso@....edu>, Randy Dunlap
<rdunlap@...otime.net>, Dave Jones <davej@...hat.com>, Chuck Wolber
<chuckw@...ntumlinux.com>, Chris Wedgwood <reviews@...cw.f00f.org>,
Michael Krufky <mkrufky@...uxtv.org>, Chuck Ebbert
<cebbert@...hat.com>, Domenico Andreoli <cavokz@...il.com>,
akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
dhaval@...ux.vnet.ibm.com

Greg, the patch in queue-2.6.23 is good for it

but the git id.: 96990a4ae979df9e235d01097d6175759331e88c

-------

>From stable-bounces@...ux.kernel.org Tue Jan 15 10:52:21 2008
From: Christoph Lameter <clameter@....com>
Date: Wed, 16 Jan 2008 00:21:19 +0530
Subject: quicklists: Only consider memory that can be used with GFP_KERNEL
To: gregkh@...e.de
Cc: Andrew Morton <akpm@...ux-foundation.org>, stable@...nel.org,
clameter@....com
Message-ID: <20080115185119.GA6806@...ux.vnet.ibm.com>
Content-Disposition: inline

From: Christoph Lameter <clameter@....com>

patch 96990a4ae979df9e235d01097d6175759331e88c in mainline.

Quicklists calculates the size of the quicklists based on the number of
free pages.  This must be the number of free pages that can be allocated
with GFP_KERNEL.  node_page_state() includes the pages in ZONE_HIGHMEM and
ZONE_MOVABLE which may lead the quicklists to become too large causing OOM.

Signed-off-by: Christoph Lameter <clameter@....com>
Tested-by: Dhaval Giani <dhaval@...ux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

---
 mm/quicklist.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

--- a/mm/quicklist.c
+++ b/mm/quicklist.c
@@ -26,9 +26,17 @@ DEFINE_PER_CPU(struct quicklist, quickli
 static unsigned long max_pages(unsigned long min_pages)
 {
 	unsigned long node_free_pages, max;
+	struct zone *zones = NODE_DATA(numa_node_id())->node_zones;
+
+	node_free_pages =
+#ifdef CONFIG_ZONE_DMA
+		zone_page_state(&zones[ZONE_DMA], NR_FREE_PAGES) +
+#endif
+#ifdef CONFIG_ZONE_DMA32
+		zone_page_state(&zones[ZONE_DMA32], NR_FREE_PAGES) +
+#endif
+		zone_page_state(&zones[ZONE_NORMAL], NR_FREE_PAGES);

-	node_free_pages = node_page_state(numa_node_id(),
-			NR_FREE_PAGES);
 	max = node_free_pages / FRACTION_OF_NODE_MEM;
 	return max(max, min_pages);
 }



On 2/6/08, Greg KH <greg@...ah.com> wrote:
> On Fri, Feb 01, 2008 at 05:30:14PM -0800, Christoph Lameter wrote:
> > On Fri, 1 Feb 2008, Justin M. Forbes wrote:
> >
> > >
> > > On Fri, 2008-02-01 at 16:39 -0800, Christoph Lameter wrote:
> > > > NO! Wrong fix. Was dropped from mainline.
> > >
> > > What is the right fix for the OOM issues with 2.6.22? Perhaps
> > > http://marc.info/?l=linux-mm&m=119973653803451&w=2 should be added to
> > > the queue in its place?  The OOM issue in 2.6.22 is real, and should be
> > > addressed.
> >
> > Indeed that is the right fix.
>
> Can someone send it to me, in patch form so that I can apply it?  Along
> with the git id of the same patch in mainline please, I can't seem to
> find it.
>
> thanks,
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
Thanks,
Oliver



-- 
Thanks,
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/