linux-kernel - Re: [PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47ADD762.1010206@web.de>
Date:	Sat, 09 Feb 2008 17:40:02 +0100
From:	Jan Kiszka <jan.kiszka@....de>
To:	jason.wessel@...driver.com
CC:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

jason.wessel@...driver.com wrote:
> @@ -2175,9 +2187,9 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
>  
>  		/*
>  		 * Power down all ports by default, except the
> -		 * console if we have one.
> +		 * console (real or kgdb) if we have one.
>  		 */
> -		if (!uart_console(port))
> +		if (!uart_console(port) && !uart_kgdb(port))
>  			uart_change_pm(state, 3);

Jason, thinking about this hunk again, it appears broken to me. If we
needed it for 8250_kgdb, we would also need it without
CONFIG_KGDB_CONSOLE. However, powering on the UART with a special dance
after we took over with 8250_kgdb is a job that has to be done _there_,
not by this hook here. So let's drop the whole serial_core.c hunk from
this patch.

Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/