linux-kernel - Re: [PATCH] affs: fix shadowed variable sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1202526084.6113.6.camel@localhost>
Date:	Fri, 08 Feb 2008 19:01:24 -0800
From:	Joe Perches <joe@...ches.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Roman Zippel <zippel@...ux-m68k.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] affs: fix shadowed variable sparse warnings

On Fri, 2008-02-08 at 18:53 -0800, Harvey Harrison wrote:
> diff --git a/fs/affs/file.c b/fs/affs/file.c
> index 6e0c939..ac05dc2 100644
> --- a/fs/affs/file.c
> +++ b/fs/affs/file.c
> @@ -570,11 +570,11 @@ affs_extent_file_ofs(struct inode *inode, u32 newsize)
>  		bh->b_state &= ~(1UL << BH_New);
>  		mark_buffer_dirty_inode(bh, inode);
>  		if (prev_bh) {
> -			u32 tmp = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);
> -			if (tmp)
> -				affs_warning(sb, "extent_file_ofs", "next block already set for %d (%d)", bidx, tmp);
> +			u32 _tmp = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);

Perhaps u32 next = be32_to_cpu(AFFS_DATA_HEAD(prev_bh)->next);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/