linux-kernel - Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080209072242.GA31231@lst.de>
Date:	Sat, 9 Feb 2008 08:22:42 +0100
From:	Christoph Hellwig <hch@....de>
To:	Erez Zadok <ezk@...sunysb.edu>
Cc:	Christoph Hellwig <hch@....de>, akpm@...l.org,
	rdunlap@...otime.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit

On Sat, Feb 09, 2008 at 02:19:27AM -0500, Erez Zadok wrote:
> >   * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
> >   * invokes * filesystem specific ->ioctl method.  If neither method exists,
>               ^
> 
> I also think this extra '*' in the last comment line above is spurious,
> perhaps the result of a paragraph reformatting command that mixed comment
> *'s with text.

Indeed.  Updated patch below:


Index: linux-2.6/fs/ioctl.c
===================================================================
--- linux-2.6.orig/fs/ioctl.c	2008-02-09 07:51:31.000000000 +0100
+++ linux-2.6/fs/ioctl.c	2008-02-09 08:21:30.000000000 +0100
@@ -18,12 +18,12 @@
 
 /**
  * vfs_ioctl - call filesystem specific ioctl methods
- * @filp: [in]     open file to invoke ioctl method on
- * @cmd:  [in]     ioctl command to execute
- * @arg:  [in/out] command-specific argument for ioctl
+ * @filp:	open file to invoke ioctl method on
+ * @cmd:	ioctl command to execute
+ * @arg:	command-specific argument for ioctl
  *
  * Invokes filesystem specific ->unlocked_ioctl, if one exists; otherwise
- * invokes * filesystem specific ->ioctl method.  If neither method exists,
+ * invokes filesystem specific ->ioctl method.  If neither method exists,
  * returns -ENOTTY.
  *
  * Returns 0 on success, -errno on error.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/