linux-kernel - Re: Kernel Panic in MPT SAS on 2.6.24 (and 2.6.23.14, 2.6.23.9)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 10 Feb 2008 18:48:08 +0100
From:	Maximilian Wilhelm <max@...2324.org>
To:	Krzysztof Oledzki <olel@....pl>
Cc:	Maximilian Wilhelm <max@...2324.org>, linux-kernel@...r.kernel.org,
	Eric.Moore@....com
Subject: Re: Kernel Panic in MPT SAS on 2.6.24 (and 2.6.23.14, 2.6.23.9)

Am Sunday, den 10 February hub Krzysztof Oledzki folgendes in die Tasten:

> >I did a git bisect between v2.6.22 v2.6.23 and it seems that
> > 6cb8f91320d3e720351c21741da795fed580b21b
> >introduced some badness.

> Thanks! This was *really* useful!

> Now, how about attached patch? Should work with both 2.6.23 and 2.6.24.

I build a patched 2.6.24 and it bootet without a problem.

> [SCSI] mpt fusion: Don't oops if NumPhys==0

> Don't oops if NumPhys==0, instead return -ENODEV.
> This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=9909
 
> Signed-off-by: Krzysztof Piotr Oledzki <ole@....pl>
Tested-by: Maximilian Wilhelm <max@...2324.org>

> diff -Nur a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> --- a/drivers/message/fusion/mptsas.c	2007-10-09 22:31:38.000000000 +0200
> +++ b/drivers/message/fusion/mptsas.c	2008-02-10 17:38:51.000000000 +0100
> @@ -1772,6 +1772,11 @@
>  	if (error)
>  		goto out_free_consistent;
>  
> +	if (!buffer->NumPhys) {
> +		error = -ENODEV;
> +		goto out_free_consistent;
> +	}
> +
>  	/* save config data */
>  	port_info->num_phys = buffer->NumPhys;
>  	port_info->phy_info = kcalloc(port_info->num_phys,

Many Thanks!

Ciao
Max
-- 
	Follow the white penguin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/