linux-kernel - Re: [PATCH 8/8] : Use FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080210211258.GE1754@martell.zuzino.mipt.ru>
Date:	Mon, 11 Feb 2008 00:12:58 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	vladislav.yasevich@...com, sri@...ibm.com,
	lksctp-developers@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 8/8] : Use FIELD_SIZEOF

On Sun, Feb 10, 2008 at 09:16:04PM +0100, Julia Lawall wrote:
> --- a/include/net/sctp/sctp.h
> +++ b/include/net/sctp/sctp.h
> @@ -618,7 +618,7 @@ static inline int param_type2af(__be16 t
>  static inline int sctp_sanity_check(void)
>  {
>  	SCTP_ASSERT(sizeof(struct sctp_ulpevent) <=
> -		    sizeof(((struct sk_buff *)0)->cb),
> +		    FIELD_SIZEOF(struct sk_buff, cb),
>  		    "SCTP: ulpevent does not fit in skb!\n", return 0);
>  
>  	return 1;

Same here. Use BUILD_BUG_ON instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/