linux-kernel - Re: [PATCH] splice: fix user pointer access in get_iovec_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080210233703.GR8953@1wt.eu>
Date:	Mon, 11 Feb 2008 00:37:04 +0100
From:	Willy Tarreau <w@....eu>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	stable@...nel.org, jens.axboe@...cle.com,
	akpm@...ux-foundation.org, bastian@...di.eu.org, ndenev@...il.com,
	oliver.pntr@...il.com
Subject: Re: [PATCH] splice: fix user pointer access in get_iovec_page_array()

On Sun, Feb 10, 2008 at 04:47:57PM +0200, Pekka J Enberg wrote:
> From: Bastian Blank <bastian@...di.eu.org>
> 
> The commit 8811930dc74a503415b35c4a79d14fb0b408a361 ("splice: missing user
> pointer access verification") added access_ok() to copy_from_user_mmap_sem()
> which only ensures we can copy the struct iovecs from userspace to the kernel
> but we also must check whether we can access the actual memory region pointed
> to by the struct iovec to close the local root exploit.
> 
> Cc: <stable@...nel.org>
> Cc: Jens Axboe <jens.axboe@...cle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
> Bastian, can I have your Signed-off-by for this, please? Oliver, Niki, can 
> you please confirm this closes the hole?

Pekka, I confirm that it also closes the hole once backported to 2.6.22.

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/