lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Feb 2008 01:13:09 +0100 (CET) From: Jan Engelhardt <jengelh@...putergmbh.de> To: Arjan van de Ven <arjan@...radead.org> cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, mingo@...e.hu, davej@...hat.com Subject: Re: [PATCH] make /dev/kmem a config option On Feb 10 2008 15:55, Arjan van de Ven wrote: >+#ifdef CONFIG_DEVKMEM > /* > * This function reads the *virtual* memory as seen by the kernel. > */ >@@ -585,6 +588,11 @@ static ssize_t write_kmem(struct file * file, const char __user * buf, > *ppos = p; > return virtr + wrote; > } >+#else >+#define read_kmem NULL >+#define write_kmem NULL >+#define mmap_kmem NULL >+#endif Is the #else case needed? All kmem_fops uses seem #ifdef'ed out anyway, except kmem_fops itself. In other words, +#ifdef CONFIG_DEVKMEM static const struct file_operations kmem_fops = { ... } +#endif and do away with the three defines. No? :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists