linux-kernel - Re: kgdb in git-x86#mm review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B071DA.305@rtr.ca>
Date:	Mon, 11 Feb 2008 11:03:38 -0500
From:	Mark Lord <lkml@....ca>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: kgdb in git-x86#mm review

Andi Kleen wrote:
> ..
> You should probably use simple_strtoul() instead of inventing an
> own hex parser in kgdb.c. And sprintf instead of an own hex writer.
> In general more use sprintf would probably shorten a lot of the parser
> code.
..

Speaking of which.. the kernel implementation of snprintf() seems
to have a bug somewhere, in that it returns an incorrect count in
some situations -- mostly around where the buffer is too small to
hold the data being written.  There's an off-by-one bug there somewhere,
but I have not had time yet to track it down more precisely.

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/