linux-kernel - Re: [PATCH] x86 (Linux Tiny): configure out support for some processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47B0D363.1020302@zytor.com>
Date:	Mon, 11 Feb 2008 14:59:47 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Michael Opdenacker <michael-lists@...e-electrons.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org,
	Linux-tiny@...enic.com
Subject: Re: [PATCH] x86 (Linux Tiny): configure out support for some processors

Michael Opdenacker wrote:
> 
> Also note that for the sake of convenience and consistency
> between 32 and 64 bit, I move the declaration of force_mwait
> from kernel/cpu/amd.c to kernel/setup_32.c 
> (force_mwait is already defined in kernel/setup_64.c).
> 

NAK NAK NAK NAK NAK NAK NAK

This is the totally wrong thing to do.  The CPU initialization stuff 
should move *into* the CPU directory (unification based on the 
cleaned-up 32-bit code, not on the 64-bit code which is based on a fork 
of the pre-cleanup 32-bit code.)

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/