| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080211095018.6AF7E1B41CE@basil.firstfloor.org> Date: Mon, 11 Feb 2008 10:50:18 +0100 (CET) From: Andi Kleen <ak@...e.de> To: tglx@...utronix.de, mingo@...e.hu, linux-kernel@...r.kernel.org Subject: [PATCH] [3/8] CPA: Fix some incorrect comments in the debug pagealloc code Even with the pool cpa in debug_pagealloc can fail (e.g. consider memory hotplug) Also the code does not clear PSE anymore as the comment claims. Replace wrong comment with correct one. Signed-off-by: Andi Kleen <ak@...e.de> --- arch/x86/mm/pageattr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) Index: linux/arch/x86/mm/pageattr.c =================================================================== --- linux.orig/arch/x86/mm/pageattr.c +++ linux/arch/x86/mm/pageattr.c @@ -864,10 +864,7 @@ void kernel_map_pages(struct page *page, if (!debug_pagealloc_enabled) return; - /* - * The return value is ignored - the calls cannot fail, - * large pages are disabled at boot time: - */ + /* This can fail in theory but then you're out of luck */ if (enable) __set_pages_p(page, numpages); else -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists