linux-kernel - Re: build #345 issue for v2.6.25-rc1 in tuner-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Feb 2008 11:42:51 +1100
From:	tony@...eyournoodle.com (Tony Breeds)
To:	Toralf Förster <toralf.foerster@....de>
Cc:	video4linux-list@...hat.com, linux-kernel@...r.kernel.org,
	Michael Krufky <mkrufky@...uxtv.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: build #345 issue for v2.6.25-rc1 in tuner-core.c

On Mon, Feb 11, 2008 at 11:54:31AM +0100, Toralf Förster wrote:
> 
> Hello,
> 
> the build with the attached .config failed, make ending with:
> ...
>   MODPOST vmlinux.o
> WARNING: modpost: Found 12 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `set_type':
> tuner-core.c:(.text+0x8879d): undefined reference to `xc5000_attach'
> make: *** [.tmp_vmlinux1] Error 1

<snip>
Fix Build error for xc5000 tuner when built as module.

Signed-off-by: Tony Breeds <tony@...eyournoodle.com>

---
Not 100% certain this is correct but it works for me :) Michael?

 drivers/media/dvb/frontends/xc5000.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/media/dvb/frontends/xc5000.h b/drivers/media/dvb/frontends/xc5000.h
index e0e8456..32a5f1c 100644
--- a/drivers/media/dvb/frontends/xc5000.h
+++ b/drivers/media/dvb/frontends/xc5000.h
@@ -45,7 +45,8 @@ struct xc5000_config {
 /* xc5000 callback command */
 #define XC5000_TUNER_RESET		0
 
-#if defined(CONFIG_DVB_TUNER_XC5000) || defined(CONFIG_DVB_TUNER_XC5000_MODULE)
+#if defined(CONFIG_DVB_TUNER_XC5000) || \
+    (defined(CONFIG_DVB_TUNER_XC5000_MODULE) && defined(MODULE))
 extern struct dvb_frontend* xc5000_attach(struct dvb_frontend *fe,
 					  struct i2c_adapter *i2c,
 					  struct xc5000_config *cfg);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/