linux-kernel - Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802120502.48019.david-b@pacbell.net>
Date:	Tue, 12 Feb 2008 05:02:47 -0800
From:	David Brownell <david-b@...bell.net>
To:	felipe.balbi@...ia.com
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	me@...ipebalbi.com
Subject: Re: [PATCH] USB: OTG: Fix weirdnesses on enumerating partial otg devices

On Tuesday 12 February 2008, Felipe Balbi wrote:
> On Tue, Feb 12, 2008 at 02:28:53AM -0800, David Brownell wrote:
> > On Tuesday 12 February 2008, Felipe Balbi wrote:
> > > Some devices claim
> > > to be b_host even though they have an a_connector attached to it.
> > 
> > Why not just fix that bug?  Remember that's Linux code.
> 
> The device claiming to be b_host is not linux based.

Wrong ... the meaning of that flag is:  *THIS* system is a
Linux-USB OTG device which came up in B-peripheral role, and
then through the magic of HNP morphed into the B-host role.

Linux is acting as a host at that point.  So either it's
being the A-host, or the B-host.  That flag says which.  If
the other device has the A-connector, yet we're the B-host,
then right now it is acting as an A-peripheral.  That's
exactly what HNP is designed to do.

> In any case this 
> is_b_host check won't do nothing here as we should check is
> SetFeature(b_hnp_enbable) has been succesfull.

Again wrong ... if the host side's b_hnp_enable flag is set,
that means this is a Linux-USB OTG device which came up in
A-host role and enumerated some vendor's OTG device, and
then set the b_hnp_enable flag.  (So it could in the future
use HNP to become an A-peripheral, despite having started
as an A-host.)

> A device in b_host state is not enough for allowing hnp to happen.

If the system is in b_host state, then HNP *ALREADY* happened.
So it can happen again, to go back into the b_peripheral state.
(And of course, we can't set the b_hnp_enable flag in a device
which is in the a_peripheral state...)

Seems like the root cause of the problem here is that you
have some correctly functioning code, but for some reason
you're surprised by that correct functioning.  (Maybe this
is a case where neither device is on the other's whitelist?)

- Dave

p.s. http://www.linux-usb.org/gadget/h2-otg.html
     does talk about those two bits, albeit succinctly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/