linux-kernel - Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Feb 2008 16:12:25 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Carlos Corbacho <carlos@...angeworlds.co.uk>,
	Len Brown <lenb@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled


* Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> @@ -673,11 +673,11 @@ static int __init acpi_wmi_init(void)
>  {
>  	acpi_status result;
>  
> +	INIT_LIST_HEAD(&wmi_blocks.list);
> +
>  	if (acpi_disabled)
>  		return -ENODEV;
>  
> -	INIT_LIST_HEAD(&wmi_blocks.list);
> -

test results: i've turned the WMI options back on earlier today on 
latest -git which has your patch above, and those crashes i reported 
disappeared. So the problem is fixed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/