[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3f1a065b0802121121s3a04c264xfd6f1311272588fc@mail.gmail.com>
Date: Tue, 12 Feb 2008 11:21:12 -0800
From: "Russell Leidich" <rml@...gle.com>
To: "Andi Kleen" <andi@...stfloor.org>,
"Torsten Kaiser" <just.for.lkml@...glemail.com>,
"Andrew Morton" <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org,
"Thomas Gleixner" <tglx@...utronix.de>,
"Ingo Molnar" <mingo@...e.hu>, valdis.kletnieks@...edu
Subject: Re: [PATCH] Remove Barcelona Thermal Throttling
All,
Sorry this took so long. I have attached the Kconfig changes
requested by Andi, appended to the original patch.
On Feb 4, 2008 11:22 AM, Russell Leidich <rml@...gle.com> wrote:
> On Feb 3, 2008 11:20 PM, Andi Kleen <andi@...stfloor.org> wrote:
> > On Sun, Feb 03, 2008 at 10:13:53PM -0800, Russell Leidich wrote:
> > > All,
> > >
> > > You can imagine my dismay when I recently learned that, after all our
> > > collective effort, hardware thermal throttling does not work reliably
> > > on Barcelona, according to AMD. Due to NDA restrictions, I am unable
> > > to provide further details.
> >
> > Too bad. Hopefully that code will work then on the hypothetic
> > future parts with fixed throttling. Perhaps it would be better
> > to just remove it now and readd later.
>
> I really think it's best to leave it in. It's harmless at the moment,
> and readding it later will just create a massive amount of duplicate
> work. Sooner or later, I'm have little doubt that AMD can make this
> feature work.
>
> >
> > All this reminds me you need to adjust the Kconfig dependencies
> > for K8_NB too to be always enabled with MCE_AMD.
> >
> > Ideally on top of this patch with a || MCE_AMD
>
> OK, if you'll take the patch, I'd be happy to do this :). I'm
> assuming that you mean I should force K8_NB = "yes" if MCE_AMD = "yes"
> in .config. Is that what you're asking for?
>
> >
> > -Andi
--
Russell Leidich
View attachment "patch.txt" of type "text/plain" (3048 bytes)
Powered by blists - more mailing lists