linux-kernel - Re: [PATCH 0/8] Create and populate toplevel tests/ for kernel tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080212132246.aac67ed1.akpm@linux-foundation.org>
Date:	Tue, 12 Feb 2008 13:22:46 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	ananth@...ibm.com, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, mingo@...e.hu, ak@...e.de,
	hch@...radead.org, sam@...nborg.org, arjan@...ux.intel.com
Subject: Re: [PATCH 0/8] Create and populate toplevel tests/ for kernel
 tests

On Tue, 12 Feb 2008 11:44:52 -0500
Christoph Hellwig <hch@...radead.org> wrote:

> On Mon, Feb 11, 2008 at 04:14:52PM +0530, Ananth N Mavinakayanahalli wrote:
> > The following series of patches create and populate the toplevel tests/
> > directory. This will henceforth be the place where all in-kernel tests
> > live.
> > 
> > All patches against 2.6.25-rc1 and are just code movement without any
> > change in functionality.
> 
> ACK to patches 1-7, and I agree with Ingo that the x86-specific test
> should stay under arch/x86.

OK.  But now is basically the worst time for me (or anyone else) to merge
large code-motion changes like this, because they need to be carried for
two months or more.

And even though git can track renames, putting them into a git tree (say,
git-kbuild) won't help, because if some other git tree tries to modify a
file in its original place, I get to fix up the fallout.

Which I _could_ do, and would do if the patches were particularly risky or
added/changed functionality or whatever.  But they don't do that, and there
is little advantage in maintaining them for the >2 months.

So.  Please redo and resend the patches when we hit 2.6.25-rc6 or so?

Thanks.

(linux-next will largely fix all this: git will take care of the renames
and I'll just base the -mm queue on the consolidated linux-next.  But we
aren't there yet).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/