linux-kernel - Re: [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Feb 2008 15:27:29 -0700
From:	"Dan Williams" <dan.j.williams@...el.com>
To:	"Haavard Skinnemoen" <hskinnemoen@...el.com>
Cc:	"Olof Johansson" <olof@...om.net>, linux-kernel@...r.kernel.org,
	"Shannon Nelson" <shannon.nelson@...el.com>,
	"David Brownell" <david-b@...bell.net>, kernel@...32linux.org,
	"Francis Moreau" <francis.moro@...il.com>,
	"Paul Mundt" <lethal@...ux-sh.org>,
	"Vladimir A. Barinov" <vbarinov@...mvista.com>,
	"Pierre Ossman" <drzeus-list@...eus.cx>
Subject: Re: [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users

On Feb 12, 2008 3:13 PM, Haavard Skinnemoen <hskinnemoen@...el.com> wrote:
> On Tue, 12 Feb 2008 14:43:30 -0600
> Olof Johansson <olof@...om.net> wrote:
>
> > > -   depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
> > > +   depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || AVR32
> >
> > This is a slippery slope. Things should be the other way around instead,
> > create a HAVE_DMA_DEVICE, select it in the relevant platform code and
> > make DMADEVICES depend on that.
>
> Agree. I'll cook up a patch tomorrow to make it use the new HAVE_*
> scheme.
>

I suggested something similar here:
http://marc.info/?l=linux-kernel&m=118670671806100&w=2

> > Or just let the subsystem always be available.
>
> It used to be always available, but then it was changed. Assuming there
> was a reason for this change, I guess we don't want to change it back.
>

Adrian had concerns about users enabling NET_DMA when the hardware
capability is relatively rare.  So, +1 for HAVE_DMA_DEVICE

> Haavard

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/