linux-kernel - Re: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080212151602.f1803ef0.akpm@linux-foundation.org>
Date:	Tue, 12 Feb 2008 15:16:02 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Paul Clements <paul.clements@...eleye.com>
Cc:	jens.axboe@...cle.com, randy.dunlap@...cle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler

On Sat, 09 Feb 2008 08:30:40 -0500
Paul Clements <paul.clements@...eleye.com> wrote:

> +		old_e = disk->queue->elevator;
> +		if (elevator_init(disk->queue, "deadline") == 0 ||
> +			elevator_init(disk->queue, "noop") == 0) {
> +				elevator_exit(old_e);
> +		}
>  	}

afacit elevator_init() will not trigger a request_module().  And you really
do want to trigger the request_module() here.  Perhaps the block layer
should provide a means of doing so?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/