linux-kernel - Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Feb 2008 10:18:53 +0100
From:	"Diego Guella" <diego.guella@...comtech.com>
To:	"Steve Wise" <swise@...ngridcomputing.com>,
	"Roland Dreier" <rdreier@...co.com>
Cc:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<general@...ts.openfabrics.org>
Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

One question below


----- Original Message ----- 
From: "Roland Dreier" <rdreier@...co.com>
To: "Steve Wise" <swise@...ngridcomputing.com>
Cc: <netdev@...r.kernel.org>; <linux-kernel@...r.kernel.org>; <general@...ts.openfabrics.org>
Sent: Wednesday, February 13, 2008 1:26 AM
Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.


> applied, although:
> 
> > +static void is_loopback_dst(struct iw_cm_id *cm_id)
> > +{
> > + struct net_device *dev;
> > + 
> > + dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr);
> > + if (!dev)
> > + return 0;

how can a static void function return 0?
%)

> > + dev_put(dev);
> > + return 1;

same here


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/